WebLoginPE v1.3.1 Bugfix (Released August 5th!)

[Guest]

Welcome, Guest. Please login or register.
Did you miss your activation email?

1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Soshite]

http://modxcms.com/WebLoginPE-1.3.1-2142.html

IT'S RELEASED! 

[rthrash]

Thank you Soshite ... we'll start testing soon on this end ... wow what a log of updates!

[Soshite]

Thank you Soshite ... we'll start testing soon on this end ... wow what a log of updates!

Most of these were mainly misspellings, or unforeseen issues like the rare UTF-8 stuff. Only a few were critical ones (basically the ones pixelchutes posted xd).

Thank goodness there wasn't nothing that completely brought down the script (well, save that user corrupting issue, if you happened to have a user put specific stuff in there).

EDIT: I forgot to mention that I am planning on using that JS IE fix pixelchutes posted in the Bug Reports topic in the final v1.3.1 release. IIRC, that was solely an IE fix, so I'll need to make up documentation to apply it just for that browser. The "normal" JS file was fine for other browsers, right, or was pixel's JS for every browser?

Also, I'll be adding documentation on a rare absolute lang path issue (where the user needs to direct WLPE to the the file directly, instead of through MODx) that will stop the lang strings from appear at all, as well as a workaround to get checkboxes to control images (until v1.4.0 is released, where Scotty will add HTML capability for form fields) --- this is useful in getting badges, achievements, etc. for your WLPE install. Lastly, I'll have documentation reminding people about which form fields needs to passed in when you have a "minimal" form (such as just a checkbox for certain data, outside of the normal profile editor) --- else WLPE "nukes" everything --- although I think pixelchutes might have fixed this bug, so I'll have to test and see if that's still the case.

[Uncle68]

Wow, there must be a lot of work fixing all that! Would almost been easier to write a completely new snippet!

That "rare UTF-8 stuff" is very important if using a non-english language as many of us do.

I'll set up e fresh install and start testing it asap!

[SimonMW]

Thanks Soshite! I'll upload this one to my site in progress and give it a go

It is a shame that Scotty isn't actively developing this any more though.  Of all the Modx snippets this one had the most potential to help make very social networking style Modx websites out of the box so to speak.

[SimonMW]

Okay, first issue I have found.

When I log in using the snippet I get a parser error

« MODx Parse Error »

MODx encountered the following error while attempting to parse the requested resource:
« PHP Parse Error »
 
PHP error debug
  Error:   Object of class DocumentParser could not be converted to string   
  Error type/ Nr.:    - 4096   
  File:   /homepages/37/d150733502/htdocs/coolactiv/assets/snippets/webloginpe/webloginpe.class.php   
  Line:   2147   
  Line 2147 source:    $$modx->sendRedirect($url,0,'REDIRECT_HEADER'); // CREDIT: Guillaume to redirect directely   
 
Parser timing
  MySQL:   0.1080 s   (19 Requests)
  PHP:   0.3706 s   
  Total:   0.4786 s

When I click the 'back' button in the browser after seeing this message I find that I have been logged in. But if I click to log out I get that parser error again.

[mbrinson]

Probably the extra '$' in $$modx->....   No?

Code:

Line 2147 source:    $$modx->sendRedirect($url,0,'REDIRECT_HEADER'); // CREDIT: Guillaume to redirect directely   

[Soshite]

Probably the extra '$' in $$modx->....   No?

Code:

Line 2147 source:    $$modx->sendRedirect($url,0,'REDIRECT_HEADER'); // CREDIT: Guillaume to redirect directely   

Gah...stupid copy & paste.

I bet that's likely it. I don't have the time ATM, but I'll reupload a "fixed" version if that was the case.

[TasDeveloper]

Actually, this whole section needs to be fixed, as far as I can see:

Code:

if (!empty($this->liHomeId))
{
if (is_array($this->liHomeId))
{
foreach($this->liHomeId as $id)
{
            $id = trim($id);
            if ($modx->getPageInfo($id))
{
$url = $modx->makeURL($id);
        $$modx->sendRedirect($url,0,'REDIRECT_HEADER'); // CREDIT: Guillaume to redirect directely
        return;
}
        }
}
else
{
$url = $modx->makeURL($this->loHomeId);
        $$modx->sendRedirect($url,0,'REDIRECT_HEADER'); // CREDIT: Guillaume to redirect directely
        return;
}
}
else
{
$url = $modx->makeURL($modx->documentIdentifier);
        $$modx->sendRedirect($url,0,'REDIRECT_HEADER'); // CREDIT: Guillaume to redirect directely
}

as there are three instances of the $$ - mine crashed on Line 2162.

[TasDeveloper]

Oh, and in the next function down LogoutHomePage:

Code:

if (!empty($this->loHomeId))
{
$url = $modx->makeURL($this->loHomeId);
$$modx->sendRedirect($url,0,'REDIRECT_HEADER'); // CREDIT: Guillaume to redirect directely
        return;
}
else
{
$url = $modx->makeURL($modx->documentIdentifier);
        $$modx->sendRedirect($url,0,'REDIRECT_HEADER'); // CREDIT: Guillaume to redirect directely
}

[Soshite]

Gah...

I'll do a quick search for these double values. Notepad++ has been acting up on the latest versions, but I didn't know it was doing that. x_x

I'll get an updated version up in a few minutes.

EDIT: And now it should be updated.

BTW, for those that have better PHP knowledge, there's a few bug fixes that I didn't know how to implement, so if you guys could help me out on that, I'd be grateful. It should be documented as to which bugs are still outstanding.

[vhollo]

In function ViewAllUsers, line 1306:

Code:

$value = strftime('%m-%d-%Y', $value);

and function PlaceHolders, line 1840:

Code:

$value==0?'':$modx->setPlaceholder('user.'.$key, strftime('%m-%d-%Y', $value));

Shouldn't the '%m-%d-%Y' have been changed to $this->DateFormat in order to format the date the way users set it to?
Of course in this case it's better set the &dateFormat to something rather than to let the snippet use the default value of '%A %B %d, %Y at %I:%M %p' since a birth date with Hours:Minutes:Seconds look stupid...

[Soshite]

IIRC, I swore I remember seeing Scotty talk about why that was like that in the v1.3.x releases. Maybe due to how he coded that part of the script.

Although that might be a good idea to look into that as a small fix for a v1.3.2 release (since v1.3.1 is purely bugfix-only, unless something new is essential to include).

BTW, I'm going to run this on my website. Hopefully things will go well.

[Soshite]

« MODx Parse Error »MODx encountered the following error while attempting to parse the requested resource:
« PHP Parse Error »
 
PHP error debug
  Error:    move_uploaded_file(/hsphere/local/home/symphoni/symphonicheaven.com/wilhelm.png): failed to open stream: Permission denied   
  Error type/ Nr.:    Warning - 2   
  File:    /hsphere/local/home/symphoni/symphonicheaven.com/assets/snippets/webloginpe/webloginpe.class.php   
  Line:    2525   
  Line 2525 source:    if (!move_uploaded_file($_FILES['photo']['tmp_name'], $userImage))    
 
Parser timing
  MySQL:    0.0246 s   (27 Requests)
  PHP:    0.4049 s   
  Total:    0.4295 s

I got that error when trying to upload a avatar. For some reason, it's messing up the path. Was this a bug I missed, or a goof I made?

EDIT: I also noticed a quirk on some servers (namely mine). When including the lang file, it seems include_once doesn't work, and I had to rename it to include. Is there an issue there?

[vhollo]

In function ViewAllUsers, line 1306:

Code:

$value = strftime('%m-%d-%Y', $value);

and function PlaceHolders, line 1840:

Code:

$value==0?'':$modx->setPlaceholder('user.'.$key, strftime('%m-%d-%Y', $value));

Shouldn't the '%m-%d-%Y' have been changed to $this->DateFormat in order to format the date the way users set it to?
Of course in this case it's better set the &dateFormat to something rather than to let the snippet use the default value of '%A %B %d, %Y at %I:%M %p' since a birth date with Hours:Minutes:Seconds look stupid...

IIRC, I swore I remember seeing Scotty talk about why that was like that in the v1.3.x releases. Maybe due to how he coded that part of the script.

Although that might be a good idea to look into that as a small fix for a v1.3.2 release (since v1.3.1 is purely bugfix-only, unless something new is essential to include).

BTW, I'm going to run this on my website. Hopefully things will go well.

You might be right: in cases the displayed date is being posted again that's right to show it in the original '%m-%d-%Y' format as it's going to be parsed by the snippet and will be saved. In cases the date will only be showed, '$this->DateFormat' will be OK.
So one would check each appearance in the class.
One I found must leave is line 1353:
$modx->setPlaceholder('view.dob', strftime('%m-%d-%Y', $viewUser['dob']));
because this one is showing on the edit form of manager mode.