200 error code being sent on 404 page instead of 404

[Guest]

Welcome, Guest. Please login or register.
Did you miss your activation email?

1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[chucky]

it doesn't work ....
when i look at the response header of the page ( with the FF Web Dev Toolbar Extension ), there is a "404 OK", weird isn't it ? ( it seems the snippet couldn't "override" the header that was sent first )
thx

if you have any fix, please share

[Mark]

That won't work because headers need to be sent before page content. PHP may just be surpressing its errors...

[PaulGregory]

There are of course a near-infinite number of 404 "pages", and this is potentially a major issue.

The problem was actually fixed, and then accidentaly unfixed in the process of putting out the security release recently. Look for an update very soon with a fix (again  )

It's being worked on as quickly as possible. If it's that urgent, you're certainly welcome to grab the code and submit a patch if you can get to it faster than the coding team.

Some clue of how fast the coding team would otherwise get to it (and Victor, it's assigned to you) would be helpful in figuring out whether I can get to it faster!

This isn't as urgent as I first thought, as I've realised there's another solution to the Google issue (see below) - but still I expect fake 404 pages to pass a 404 code to the agent if not the server and would be happier if MODx did that.

If it's going to be more than a week or so, then I volunteer to pick up your previous fixed code and reapply it to 0.9.2.1. If you could just tell me where I can grab that fixed code from!

The bug report at http://modxcms.com/bugs/task/255?tasks=last mentions a fix at : http://modxcms.com/forums/index.php/topic,1052.0.html but I cannot access that forum page - if you could please PM me the code, it would make this do-able.

Alternatively, if you can't get the code to me, let me know and I'll investigate other avenues.

Fixing the Google issue
There are also 2 potential ways of solving the Google problem, by asking it not to index the fake 404 pages:
1) Custom robots.txt file with known (old) pages disallowed
2) Add

Code:

<META NAME="ROBOTS" CONTENT="NOINDEX, NOFOLLOW">

to a custom template for the 404 page. (I guess you only want NOINDEX there but I don't know if that would work so it's probably best to leave it as per the official example.)
For more on this angle, see http://www.google.com/support/webmasters/bin/answer.py?answer=35303

I'm going to put the meta tag in my 404 template, it seems the best way forward.

[chucky]

thx for the tip, i didn't think to the search engines tags !

[chucky]

hi again 
i added the robots meta tag in the 404 error page, i hope it will work ( google doesn't seem to crawl my site very often ... )
by the way, i am trying the etomite fix ( see the 1st post of this thread ), the solution is to modify the index.php file around line 700, but mine only have 100 ones  at most ...

[vbrilon]

hi again 
i added the robots meta tag in the 404 error page, i hope it will work ( google doesn't seem to crawl my site very often ... )
by the way, i am trying the etomite fix ( see the 1st post of this thread ), the solution is to modify the index.php file around line 700, but mine only have 100 ones  at most ...

The Eto fix won't work with the latest release we have. Due to security related issues, much of the page rendering logic was changed, and unfortunately the 404 fix we had is no longer valid. It's definitely high up on my to-do list, but unfortunately paying work comes first 

[openagate]

Hi All!

upd:

I created plugin with code:

Code:

if ($modx->documentIdentifier == (id of error page ;) I'm not a php-master, by hands )) {
                 $header = "HTTP/1.0 404 Not Found\n";
                 header($header);
                                                             }

on System Events page selected  Template Service Events->OnWebPagePrerender & Parser Service Events->OnPageNotFound...

it's likely  it works

[vbrilon]

I *think* (and I am not 100% positive since I am not looking at the code now) that by the time that system event gets called, it's too late in some instances to deal with a 404 response.

I'll look into it this weekend and see if I can find where in the code it's happening and just fix it once and for all

[qson]

Code:

if ($modx->documentIdentifier == (id of error page ;) I'm not a php-master, by hands )) {
                 $header = "HTTP/1.0 404 Not Found\n";
                 header($header);
                                                             }

Modified it a bit...

Here we go:

Code:

if (($modx->documentIdentifier == $modx->config['error_page'])||($modx->Event=='OnPageNotFound')) {
                 $header = "HTTP/1.0 404 Not Found\n";
                 header($header);
}

Now it reads which page is the error page id and returns a 404 header.

Like openagate wrote:
Check the "OnWebPagePrerender" and "OnPageNotFound" events.

[openagate]

oh, thanx a lot...

[dbowling]

Thanks so much, that is great!!!

[lovingmodx]

You can also replace this line in document.parser.class.inc.php

Code:

$header = (($this->documentIdentifier == $this->config['error_page']) && $redirect_error) ? "HTTP/1.0 404 Not Found\n".$header : $header;

with

Code:

$header = ($this->documentIdentifier == $this->config['error_page'] or $redirect_error) ? "HTTP/1.0 404 Not Found\n" : $header;

I am sure the team will fix this on next release.

[Soda]

Hello, I have a solution without a hack (untill it is included in the next release):
create a new plugin,put header("HTTP/1.0 404 Not Found"); in the content and check the event OnPageNotFount

That's all.

[zi]

Hello, I have a solution without a hack (untill it is included in the next release):
create a new plugin,put header("HTTP/1.0 404 Not Found"); in the content and check the event OnPageNotFount
That's all.

Great!

Thanks for the solution!

regards.

zi

[rthrash]

Hello, I have a solution without a hack (untill it is included in the next release):
create a new plugin,put header("HTTP/1.0 404 Not Found"); in the content and check the event OnPageNotFount

Have you been able to confirm whether or not Google likes this in their sitemap service?