DropMenu. if SelfAsLink = false

[Guest]

Welcome, Guest. Please login or register.
Did you miss your activation email?

1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[openagate]

Any element of menu, if current page, -- isn't a link. SelfAsLink no more:)
Correct snatch of code by just add
$itm .= ((!$selfAsLink && ($child['id'] == $modx->documentIdentifier)) || ($itsEmpty && $useCategoryFolders)) ?
for
elseif ($isFolder && $inside):

Code:

/////////////////////////////// If at the top level
if (!$inside)
{
$itm .= ((!$selfAsLink && ($child['id'] == $modx->documentIdentifier)) || ($itsEmpty && $useCategoryFolders)) ?
                                        $pre.$child[$textOfLinks].$post . (($debugMode) ? ' self|cat' : '') : '<a href="[~'.$child['id'].'~]" title="'.$child[$titleOfLinks].'">'.$pre.$child[$textOfLinks].$post.'</a>';
$itm .= ($debugMode) ? ' top' : '';
}
/////////////////////////////// it's a folder and it's below the top level
elseif ($isFolder && $inside)
{
   
$itm .= ((!$selfAsLink && ($child['id'] == $modx->documentIdentifier)) || ($itsEmpty && $useCategoryFolders)) ?
$pre.$child[$textOfLinks].$post . (($debugMode) ? 'subfolder T': '') : '<a href="[~'.$child['id'].'~]" title="'.$child[$titleOfLinks].'">'.$pre.$child[$textOfLinks].$post.'</a>'. (($debugMode) ? ' subfolder F' :'');       
}
/////////////////////////////// it's a document inside a folder
else
{
$itm .= ($child['alias'] > '0' && !$selfAsLink && ($child['id'] == $modx->documentIdentifier)) ? $child[$textOfLinks] : '<a href="[~'.$child['id'].'~]" title="'.$child[$titleOfLinks].'">'.$child[$textOfLinks].'</a>';
$itm .= ($debugMode) ? ' doc' : '';
}

[rthrash]

What is not happening that you expect to happen?

[openagate]

So...

The site has some levels, for example:

--Level 1(start)
---------Level 11(end)
---------Level 12
----------------Level 121(end)
----------------Level 122
-----------------------Level 1221(end)
-----------------------Level 1222(end)
-----------------------Level 1223(end)
----------------Level 123(end)
---------Level 13(end)


& SelfAsLink = false

it would be desirable, that when we are at the Level 12
or at the Level 122, an active element of the menu would not be a link.
At the start or end Level -- all right -- SelfNotAsLink.

I hope, that I state clearly . English - not  my native language.



 

[rthrash]

The way the self as link should function in my mind is to turn off only for the page you're on. Was it not doing that properly?

[openagate]

The way the self as link should function in my mind is to turn off only for the page you're on.

Yes, I think so... and for ANY page we're on.

Was it not doing that properly?

No, if not make the small amendment which I have offered.

See up: If we're on the page "Level 122" and SelfAsLink = false, I  don't wanna have  page link  itself.
 

[rthrash]

Out of curiosity, which version of DropMenu are ou using? (from which MODx version)

[openagate]

oops!

I wrote:
"active element of the menu"

I mean:
"the page we're on"

[openagate]

Out of curiosity, which version of DropMenu are ou using? (from which MODx version)

MODx 0.9.0 (x9)

[openagate]

New MODx's DropMenu without problem:)

[rthrash]

Thanks for the update opengate and glad it's working now.

[openagate]

Yeh &

thank folks -- & who has created, & who helps to develop the MODx!

[yoomai]

This problem is still valid in 0.9.2.1.: If a document is a folder AND it's below the top level AND you want it not to be a link (selfAsLink=`false`) then DropMenu fails. Like topic starter wrote, change the original code at lines 238 - 245

Code:

// it's a folder and it's below the top level
elseif ($isFolder && $inside)
{
   
$itm .= ($itsEmpty && $useCategoryFolders) ?
        $pre.$child[$textOfLinks].$post . (($debugMode) ? 'subfolder T': '') :
        '<a href="[~'.$child['id'].'~]" title="'.$child[$titleOfLinks].'">'.$pre.$child[$textOfLinks].$post.'</a>'. (($debugMode) ? ' subfolder F' :'');       
}

to

Code:

// it's a folder and it's below the top level
elseif ($isFolder && $inside)
{
   
$itm .= ((!$selfAsLink && ($child['id'] == $modx->documentIdentifier)) || ($itsEmpty && $useCategoryFolders)) ?
$pre.$child[$textOfLinks].$post . (($debugMode) ? 'subfolder T': '') : '<a href="[~'.$child['id'].'~]" title="'.$child[$titleOfLinks].'">'.$pre.$child[$textOfLinks].$post.'</a>'. (($debugMode) ? ' subfolder F' :'');       
}

and you're done.

Thank you, openagate!

[ddmobley]

DropMenu also displays inconsistent with regard to "selfAsLink" activated.  If "selfAsLink" is set to true then the "here" class for the parent document is discarded.  If you are styling a menu with CSS using the "here" label, it shouldn't matter whether or not "selfAsLink" is active or not.  But DropMenu discards "here" for the parent document in the menu tree if "selfAsLink" is set to "true".

[yoomai]

DropMenu also displays inconsistent with regard to "selfAsLink" activated.  If "selfAsLink" is set to true then the "here" class for the parent document is discarded.  If you are styling a menu with CSS using the "here" label, it shouldn't matter whether or not "selfAsLink" is active or not.  But DropMenu discards "here" for the parent document in the menu tree if "selfAsLink" is set to "true".

http://modxcms.com/forums/index.php/topic,2609.msg17880.html#msg17880

[davidm]

DropMenu also displays inconsistent with regard to "selfAsLink" activated.  If "selfAsLink" is set to true then the "here" class for the parent document is discarded.  If you are styling a menu with CSS using the "here" label, it shouldn't matter whether or not "selfAsLink" is active or not.  But DropMenu discards "here" for the parent document in the menu tree if "selfAsLink" is set to "true".

I happen to encounter this very problem and it's driving me nuts !
I didn't connect it to the selfAsLink parameter, I'll try to set it to false see if it solves it... thanks for pointing that out !

I have tried the hack from Cino, but it only works with activeTreeOnly hack and I don't want that...

http://modxcms.com/forums/index.php/topic,2609.msg17880.html#msg17880

Thanks for the pointer !