TV sortorder lost when changing TV

[Guest]

Welcome, Guest. Please login or register.
Did you miss your activation email?

1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Mitch]

I noticed that the sortorder of the TV's in a template gets lost when I change a TV. For example I had my TV's sorted for my standard template. Now I change one of the TV's from "Text" to "Text area (mini)" and now the sortorder is not correct anymore.

Is this behaviour expected when I change the TV or should I file a bug report for this?

Seen on 0.9.6

[rthrash]

File a bug report please.

[FuryDE]

The same problem exists when I change the input option values (in my given case an @SELECT) of a TV. I just fixed an error and it seems that the TV I edited was set to the first (top) position.

Martin

[Mitch]

Reported: FS#926 (sorry for late reaction, been on holiday )

[Crash1hd]

I also having the same issue in 0.9.6.1B, I looked into what would be causing this issue is in the save_tmplvars.processor.php in processors file and this happens on anytime you hit save in a template variable edit state.  On line 132 it calls saveTemplateAccess() function which removes and then reinserts the id and its template (obviously removing its ranking position and putting it back at the top) not sure why this would be needed on an edit and if this line is removed it resolves this issue (but do so at your own discretion I am not liable )

I have added the same above into the bug report

Looks like a quick fix

[Crash1hd]

OK so I have been informed that by just removing the call to the function removes the ability to properly change templates.  What was I thinking of course nothing is a quick fix lol ok so I did some more research and came up with the following that restores the ability to change templates without changing the rank of the template variable.

maybe this will solve it :0)

I undid what I did above (back to the way it was) and then did the following below
in the same file I did all my modifications inside the saveTemplateAccess() function.

1. I added a global call to $modx (could have done it without but I thought why not) admin note: it is needed

2. added the floowing lines below this line

Code:

$tbl = "$dbase.`".$table_prefix."site_tmplvar_templates`";

I added the following

Code:

$getRankArrayKey = array();
$getRankArrayValue = array();

$getRank = $modx->db->select("templateid, rank", $tbl, "tmplvarid=$id");

while( $row = $modx->db->getRow( $getRank ) ) {
array_push($getRankArrayKey, $row[templateid]);
array_push($getRankArrayValue, $row[rank]);
}

$getRankArray = array_combine($getRankArrayKey,$getRankArrayValue);

3. I change the for loop to this

Code:

for($i=0;$i<count($templates);$i++){
$setRank = ($getRankArray[$templates[$i]])?$getRankArray[$templates[$i]]:0;
mysql_query("INSERT INTO $tbl (tmplvarid,templateid,rank) VALUES($id,".$templates[$i].",$setRank);");
}

seems to have fixed the issue

let me know what you think (remember I am not a modx guru by any means and again this worked for me no promises )

[rthrash]

Just to confirm this works great. Thank you.

[The Man Can!]

Is it just me, or does this hack kill the ability to remove a TV from a template? ie. Once a TV is assigned to a template, it can't be unassigned when this hack is present?

Or I could have botched the hack. If somebody could let me know it'd be great.