Topic: Anyone successfully using QuickEdit and IE7?  (Read 5293 times)

Pages: [1]   Go Down

#1: 6-Mar-2007, 09:27 AM

Coding Team
Jesse R.
Posts: 786

WWW
I am going to try and word my question a little different.  Is anyone able to get QuickEdit and IE7 working?  If so, what version are you using?  If you are using 0.9.6, what revision?
Jesse R.
Consider trying something new and extraordinary.
Illinois Wine

Have you considered donating to MODx lately?
Donate now.  Every contribution helps.

#2: 6-Mar-2007, 10:06 AM

Coding Team

sottwell
Posts: 10,439

WWW
This has been brought up a few times already; it seems to have someting to do with some code for handling transparencies somewhere. I'm not sure; try a search to get the other posts on the subject.
sottwell.com has moved to a lovely Solaris 10 server!
Log in username guest, password guestuser.
Templates are now becoming available at http://sottwell.com/templates.html

#3: 6-Mar-2007, 10:29 AM

Coding Team
Jesse R.
Posts: 786

WWW
Actually, I am getting javascript errors, so I don't think it relates to the CSS problems mentioned before.

Particularly 'qe' is undefined when clicking the "edit xxxxx" buttons, and 'toolbar' undefined when the page loads.
Jesse R.
Consider trying something new and extraordinary.
Illinois Wine

Have you considered donating to MODx lately?
Donate now.  Every contribution helps.

#4: 19-Mar-2007, 11:45 AM


StainlessSteelRat
Posts: 30

The love of my life, Leila Autumn

I'm having the same issue.  Any ideas what's causing it?  (I get the same thing in IE7 and IE6.)
I'm currently at 0.9.6-RC2 (latest SVN build to see if that would fix it), though the issue has been there since before RC1.
« Last Edit: 19-Mar-2007, 01:26 PM by StainlessSteelRat »

#5: 19-Mar-2007, 04:26 PM

Coding Team
Jesse R.
Posts: 786

WWW
I am sorry to bump this as it is really annoying some of my users that use IE7 only at work.  And now someone else is reporting the same issue.  I would have to imagine that more than two people have come across this.  Is this a bug, or some configuration problem?  ::Looks in Ryan's and Jeff's direction::
Jesse R.
Consider trying something new and extraordinary.
Illinois Wine

Have you considered donating to MODx lately?
Donate now.  Every contribution helps.

#6: 20-Mar-2007, 01:05 PM


StainlessSteelRat
Posts: 30

The love of my life, Leila Autumn

Yes... my users aren't too happy about it either.  BTW... I searched & tried the "fix" found in other postings about removing the alpha filter references from toolbar.css, but I couldn't find any.  Huh

#7: 20-Mar-2007, 02:03 PM

Coding Team
Jesse R.
Posts: 786

WWW
Plus this appears to be a javascript problem and not a CSS problem.
Jesse R.
Consider trying something new and extraordinary.
Illinois Wine

Have you considered donating to MODx lately?
Donate now.  Every contribution helps.

#8: 22-Mar-2007, 12:46 AM

Seraji
Posts: 23

WWW
Having the exact same problem here in both IE6 and 7. This problem is isolated to the new mootools driven one and only ever applies to IE, Firebug cannot detect the error.

What i get is that the toolbar appears (added to page by php/js on load?) but then it is impossible to use it at all, the error recieved on the toolbar is "toolbar is undefined, line 76 char 3" this code is
Code:
74.// Draggable toolbar title
75.  this.toolbar.makeDraggable({
76.   handle: $E('h1',toolbar),
77.  onStart:function() { this.toolbar.setStyle('opacity',0.5); }.bind(this),
78.   onComplete: function(x,y) { this.toolbar.setStyle('opacity',1);Cookie.set('QE_position', this.toolbar.getLeft()+'/'+this.toolbar.getTop(), {duration:this.cookieDuration}); }.bind(this)
  });
The first reference to 'toolbar' is several lines up and is
Code:
this.toolbar = toolbar;
  this.menu = $E('ul',toolbar);
  this.title = $E('h1',toolbar);
  this.buttons = $ES('li','QE_Toolbar');
 
which is a declaration of what toolbar is, a definition if you like, which is why FF Safari (webkit) both recognize it.
But that doesnt make sense as being the problem and here is why, from the IE developer toolbar (aka. the 'srsly why doesnt this work in IE toolbar')
Code:
/* Inline style */ { DISPLAY: block}
That inline styling is applied by the javascript here
Code:
this.toolbar.setStyle('display','block');
so that earlier declaration works here as the js is happily displaying the toolbar for us to be tricked into thinking it works.

So, lets play spot the difference, every other call to 'toolbar' is done by 'this.toolbar' only the broken one uses toolbar by itself, this is cause this.toolbar=toolbar defines this.toolbar as something, not just toolbar by itself. No idea why FF could sort that out itself but at least now it functions in IE7 (ill move to IE 6 later).

The dropdowns worked fine after that change and so did dragging, however once you dragged the bar the dropdowns ceased to display (note: the height of the menu's still changed, JS still working fine) something about how the opacity was throwing off IE7, so anyway removed the two lines about opacity, now the bar works all the time in IE7, FF and Sarafi.

Also that seems to have fixed the little edit content error (qe is not blah blah) that i also was getting.

IE 6 the bar moves but none of the dropdowns are visible and you cant click them, probably to do with css z-index as IE has issues dealing with that. They have displayed in that way since i upgraded, ill look into it when i get some more time, right now im just pleased that IE 7 can use the bar again.

Anyhow I've attached the new js to this post and its the only file i edited and tested it on my clean install of 0.9.6 SVN so i'd say its fine.

Edit: Fix for IE6 is to edit toolbar.css and cut the width of h1 down to 110px from 215px, in IE6 the faulty z-index rendering meant that h1 simply refused to let the menu show through at all.

* QuickEditFix.zip (1.72 KB - downloaded 362 times.)
« Last Edit: 22-Mar-2007, 03:21 AM by Seraji »

#9: 22-Mar-2007, 05:43 AM

g5604
Posts: 370

WWW
check this thread for the fix:

http://modxcms.com/forums/index.php?PHPSESSID=37c8e9064cf99697ecfc4cd9e393c514&/topic,10200.msg70442.html

#10: 22-Mar-2007, 11:53 AM

Coding Team
Jesse R.
Posts: 786

WWW
Seraji,

I will give that a test when I get home.  I will be absolutely thrilled if that solves the problem :-D
Jesse R.
Consider trying something new and extraordinary.
Illinois Wine

Have you considered donating to MODx lately?
Donate now.  Every contribution helps.

#11: 23-Mar-2007, 10:36 AM


StainlessSteelRat
Posts: 30

The love of my life, Leila Autumn

Seraji,
I'm really excited about this, but I can't open your attachment.  (I'm using 7-zip.)  Is anyone else having a problem with the zip file, or is it just me?
-R

#12: 23-Mar-2007, 11:56 AM

Coding Team
Jesse R.
Posts: 786

WWW
I am also using 7-Zip and the download works fine for me.  I would say that this bug is confirmed.  I filed a bug report, can anyone from the MODx team confirm this as a bug?

EDIT:  Just applied the fix and it works perfectly in IE7.  THANK YOU!
« Last Edit: 23-Mar-2007, 12:02 PM by jesster444 »
Jesse R.
Consider trying something new and extraordinary.
Illinois Wine

Have you considered donating to MODx lately?
Donate now.  Every contribution helps.

#13: 23-Mar-2007, 01:57 PM


StainlessSteelRat
Posts: 30

The love of my life, Leila Autumn

It WAS me!  I downloaded it 3 times, on two different machines (running Vista) and 7-zip and kept getting errors about an invalid archive.  I even tried unzipping one of those files on an XP machine with the same result.  Finally downloaded it AGAIN directly to the XP machine and 7-zip opened it beautifully.  Weird...

Anyway... it worked great.  Thanks a bunch Seraji !

-R

#14: 28-Mar-2007, 09:55 PM

quintont
Posts: 3

It didn't work for me.  I uploaded the QuickEdit.js file to /assets/modules/quick-edit/javascript and changed the width from 215 to 110 in /assets/modules/quick-edit/styles/toolbar.css

Am I missing something?

T.


#15: 29-Mar-2007, 09:29 AM

Coding Team
Jesse R.
Posts: 786

WWW
Are you having the problems described in this thread (i.e. 'toolbar' and 'qe' undefined javascript errors?)  If so, you might also want to try clearing your cache.  Also does it work fine in FireFox?

Jesse
Jesse R.
Consider trying something new and extraordinary.
Illinois Wine

Have you considered donating to MODx lately?
Donate now.  Every contribution helps.

#16: 31-Mar-2007, 09:30 AM

quintont
Posts: 3

Actually you're right, the javascript error has disappeared after installing the fix, but the QuickEdit menu bar stays expanded in ie6 and ie7.  Only items on the QuickMenu tab work. The content | settings | go tabs do not work.  Clicking on them, nothing happens and the menu bar is always expanded, displaying only the QuickEdit tab in expanded view.  It works fine in Firefox - menu expands on click and the content | settings | go tabs display their associated submenus when clicked.

#17: 31-Mar-2007, 10:03 AM

Coding Team
Jesse R.
Posts: 786

WWW
Ok.  That sounds like CSS problems then.  Have you also applied the fixes found here?

http://modxcms.com/forums/index.php?PHPSESSID=37c8e9064cf99697ecfc4cd9e393c514&/topic,10200.msg70442.html
Jesse R.
Consider trying something new and extraordinary.
Illinois Wine

Have you considered donating to MODx lately?
Donate now.  Every contribution helps.

#18: 11-May-2007, 03:05 PM

Foundation

rthrash
Posts: 11,284

WWW
Seraji,

Just wanted to drop a quick "thanks" for your detailed QE report. IE6-QE is the last thing holding up the official 096 release (undefined) and your research should help us cut down on the fix time. Smiley
MODx is a content managmeent framework that allows web professionals to turn over sites to end-users for daily maintenance without worrying. Please help us help you when asking for assistance and read the wiki. Searching the forums from the top level helps, too.
Ryan Thrash
MODx Co-Founder
Principal @ Collabpad
work productively.
work intelligently.
work together.

#19: 11-May-2007, 03:44 PM

Coding Team

garryn
Posts: 1,384

WWW
I'll echo the thanks that Ryan just gave, a very well-detailed explanation (and perfectly working) fix. Thank you! Smiley (and now committed)
Pages: [1]   Go Up
0 Members and 1 Guest are viewing this topic.