Login!
Lost password?
 

MODx Bug/Feature Tracker and Feature Requests

Welcome to the MODx CMS Tracker. Please choose the appropriate project from the drop down menu and provide as much information as possible regarding your server environment and browser. Thanks!

FS#896 — Document (Un)Publishing in refresh_site.dynamic.php

Attached to Project — MODx
Opened by Matthew Pietz (sirlancelot) - Friday, 15 June 2007, 03:04PM
Last edited by Matthew Pietz (sirlancelot) - Friday, 15 June 2007, 03:08PM
Task Type Bug Report
Category Core Distribution
Status Closed
Assigned To Matthew Pietz (sirlancelot)
Operating System All
Severity Low
Priority Normal
Reported Version 0.9.6
Due in Version Undecided
Due Date Undecided
Percent Complete 100%

Details

During the "Clear Cache" action I noticed something weird about the:
x documents were published.
x documents were unpublished.

section of the page. It was publishing ALL of my documents with a valid pub_date, and then un-publishing them again. Quite a bit of work for sites with lots of publish-unpublish times.

A proposed fix is in the attached patch. It basically adds another statement to the SQL query that determines if the document's unpublish date comes after the current time, and only then will it be published.

I can commit this myself, this ticket is just for formality :)

EDIT: The revision numbers in the patch file are from my own server, the patch will work on rev 2785 of branches/0.9.6   pubfix.patch
This task depends upon

This task blocks these from closing
Closed by  Matthew Pietz (sirlancelot)
Wednesday, 18 July 2007, 04:24PM
Reason for closing:  Fixed
Comment by Matthew Pietz (sirlancelot) - Friday, 15 June 2007, 03:19PM
------------------------------------------------------------------------
r2786 | sirlancelot | 2007-06-15 13:14:28 -0700 (Fri, 15 Jun 2007) | 2 lines
Changed paths:
M /tattoo/branches/0.9.6/install/changelog.txt
M /tattoo/branches/0.9.6/manager/actions/refresh_site.dynamic.php

* [ FS#896 ] Document (Un)Publishing during "Clear Cache" now accurately (Un)Publishes documents.

------------------------------------------------------------------------