Login!
Lost password?
 

MODx Bug/Feature Tracker and Feature Requests

Welcome to the MODx CMS Tracker. Please choose the appropriate project from the drop down menu and provide as much information as possible regarding your server environment and browser. Thanks!

FS#893 — stripAlias function doesn't kill html entities

Attached to Project — MODx
Opened by Matthew Pietz (sirlancelot) - Friday, 08 June 2007, 12:26PM
Last edited by Jason Coward (opengeek) - Wednesday, 24 October 2007, 12:15PM
Task Type ToDo
Category Core Distribution
Status Closed
Assigned To Jason Coward (opengeek)
Matthew Pietz (sirlancelot)
Operating System All
Severity High
Priority High
Reported Version 0.9.6
Due in Version 0.9.6.1
Due Date Undecided
Percent Complete 100%

Details

Regarding branches/0.9.6 @ r2780...
Upon looking at the code in manager/processors/save_content.processor.php I noticed that the strtr() on line 855 replaces '&' BEFORE the 'kill entities' replacement happens on line 858.

Long story short, it might be better to do an http://php.net/html_entity_decode before any translation takes place and then work from there. The html_entity_decode function is php 4.3.0 and up but there are plenty of substitute functions on the php.net info page.
This task depends upon

This task blocks these from closing
Closed by  Matthew Pietz (sirlancelot)
Wednesday, 27 February 2008, 10:50AM
Reason for closing:  None
Additional comments about closing:  Ported to Jira #MODX-50 :
http://svn.modxcms.com/jira/browse/MODX-50
Comment by Ryan Thrash (rthrash) - Friday, 08 June 2007, 12:58PM
I like the idea Matthew. Please proceed ahead, unless the 'geek objects.

Comment by Jason Coward (opengeek) - Friday, 08 June 2007, 01:04PM
How would this be better? Perhaps I need the medium length story?

Comment by Jason Coward (opengeek) - Wednesday, 24 October 2007, 12:15PM
This needs to be fixed for 0.9.6.1, in conjunction with fixes for FS#874.