Login!
Register as a new user Lost password?
 

MODx Bug/Feature Tracker and Feature Requests

Welcome to the MODx CMS Tracker. Please choose the appropriate project from the drop down menu and provide as much information as possible regarding your server environment and browser. Thanks!

FS#892 — Upgrading: 0.9.5 -> 0.9.6 Snippets upgraded regardless of whether ticked

Attached to Project — MODx
Opened by Nick Crossland (ncrossland) - Friday, 08 June 2007, 10:31AM
Last edited by Brunaud (coroico) - Sunday, 18 May 2008, 12:09PM
Task Type Bug Report
Category Install and Server Issues
Status Requires testing
Assigned To No-one
Operating System All
Severity High
Priority Urgent
Reported Version 0.9.6
Due in Version 0.9.6.2
Due Date Undecided
Percent Complete 10%

Details

When upgrading from 0.9.5 to 0.9.6, I want to retain some of the existing snippets e.g. not upgrade them. Specifically Ditto and Wayfinder.

I unticked them in the installer, but they were upgraded anyway.

This task depends upon

This task blocks these from closing
Comment by Jason Coward (opengeek) - Sunday, 23 September 2007, 01:40PM
  • Field changed: Status (Unconfirmed → Waiting on User)
  • Field changed: Due Date (Undecided → Undecided)
I'm pretty sure this is not a bug in the installer, but just a lack of understanding that overwriting any of the files in assets/snippets/* with the files from the 0.9.6 installation will require you to upgrade the actual snippet in the database as well.

In other words, if you uncheck any snippets in the installation, you must also not replace the corresponding dependent files that may exist in assets/snippets/*, or you will have an old snippet in the database with the new versions dependencies; this generally breaks the component altogether.

Comment by Jason Coward (opengeek) - Thursday, 08 November 2007, 01:55PM
  • Field changed: Status (Waiting on User → Requires testing)
  • Field changed: Due in Version (Undecided → 0.9.6.1)
  • Field changed: Percent Complete (0% → 100%)
FYI. I made some small changes to the installer for 0.9.6.1 release that may correct issues people are having with incorrect add-ons being inserted based on checkbox selections.

Comment by Jason Coward (opengeek) - Thursday, 08 November 2007, 03:33PM
  • Field changed: Status (Requires testing → Researching)
  • Field changed: Due in Version (0.9.6.1 → 0.9.6.2)
  • Field changed: Priority (Normal → Urgent)
  • Field changed: Percent Complete (100% → 10%)
Ugh, this is still messed up. I'll redo the logic and release 0.9.6.2 as quickly as we can, but I don't want to delay this any longer. It is definitely a bug though, and I will be recommending that everyone either choose all or none of the add-ons when installing 0.9.6.1. :/

Comment by Shane Sponagle (dev_cw) - Saturday, 16 February 2008, 06:56AM
The problem seemed to be with the action.summary.php file. The block begining at line 228 is not setting the array for the options correctly. I changed it as follows (changing the value="{$i}" to value="$snippet"). All seems to be working on my test environment, please confirm.

Attached modified action.sumary.php file for confirmation.

See this post in the forum:
http://modxcms.com/forums/index.php/topic,21462.msg140307.html#msg140307
  action.summary.txt
Comment by Brunaud (coroico) - Sunday, 18 May 2008, 12:09PM
I've committed the fix in SVN rev 3710.