Login!
Register as a new user Lost password?
 

MODx Bug/Feature Tracker and Feature Requests

Welcome to the MODx CMS Tracker. Please choose the appropriate project from the drop down menu and provide as much information as possible regarding your server environment and browser. Thanks!

FS#865 — regClientCSS only works when page is not cached

Attached to Project — MODx
Opened by Matthew Pietz (sirlancelot) - Thursday, 17 May 2007, 07:30PM
Last edited by Jason Coward (opengeek) - Thursday, 12 July 2007, 08:14AM
Task Type Bug Report
Category Core Distribution
Status Requires testing
Assigned To Jason Coward (opengeek)
Matthew Pietz (sirlancelot)
Operating System All
Severity Critical
Priority Normal
Reported Version 0.9.6-RC1
Due in Version 0.9.6.1
Due Date Undecided
Percent Complete 100%

Details

This is a result of some modification I made, I am working on it now and will post details when I fix it.
This task depends upon

This task blocks these from closing
Comment by Matthew Pietz (sirlancelot) - Thursday, 17 May 2007, 07:53PM
More Details, it appears that now if a snippet is executed normally (with '[[ ]]' instead of '[! !]'), then regClientCSS within that snippet will not be called once the page is cached.

I will be modifying the caching algorithm to include $modx->sjscripts and $modx->jscripts to compensate for this.

I chose this solution because going back to the previous method of injecting $sjscripts would cause duplicate code output when the page is cached.

Will fix and commit tomorrow.

Comment by Jason Coward (opengeek) - Friday, 18 May 2007, 02:43PM
Status?

Comment by Matthew Pietz (sirlancelot) - Friday, 18 May 2007, 03:43PM
Fixed @ r2748 in branches/096/

Should be tested more.

------------------------------------------------------------------------
r2748 | sirlancelot | 2007-05-18 13:40:03 -0700 (Fri, 18 May 2007) | 3 lines

* [FS#865] $sjscripts and $jscripts are now saved to the cache
* Cleaned my own code comments

------------------------------------------------------------------------

Comment by Jason Coward (opengeek) - Thursday, 12 July 2007, 08:13AM
This was still buggy in 0.9.6, causing duplication of scripts registered by non-cacheable snippets when used on cacheable pages. It is fixed in trunk and will be in 0.9.6.1.

Comment by Jeff Whitfield (Bravado) - Monday, 16 June 2008, 11:45PM
If this is fixed, can we close the bug tracker ticket? Or is it still pending?