Login!
Lost password?
 

MODx Bug/Feature Tracker and Feature Requests

Welcome to the MODx CMS Tracker. Please choose the appropriate project from the drop down menu and provide as much information as possible regarding your server environment and browser. Thanks!

FS#844 — Undefined index: cancel with BottomButtonBar

Attached to Project — MODx
Opened by Michel (Mitch) - Wednesday, 25 April 2007, 11:33AM
Last edited by Brunaud (coroico) - Friday, 09 May 2008, 05:40AM
Task Type Bug Report
Category Plugin/Module/Snippet
Status Closed
Assigned To Garry Nutting (garryn)
Operating System All
Severity Medium
Priority Normal
Reported Version 0.9.5
Due in Version 0.9.6.2
Due Date Undecided
Percent Complete 100%

Details

When a language file does not have all the strings specified and would fallback on the English language string this will not work in the BottomButtonBar plugin.

This can easily be fixed. Remove the line (line 28):
include $modx->config['base_path'].'manager/includes/lang/'.$modx->config['manager_language'].'.inc.php';

Add instead the line:
global $_lang;

Now the language file as loaded by MODx is used instead of loading the language file within the plugin.

See forum thread for original problem:
http://modxcms.com/forums/index.php/topic,5890.msg93245/topicseen.html#new
This task depends upon

This task blocks these from closing
Closed by  Brunaud (coroico)
Sunday, 11 May 2008, 03:51PM
Reason for closing:  Fixed
Comment by Brunaud (coroico) - Thursday, 08 May 2008, 03:32PM
What is the status of this issue ? This plugin seems deprecated since the complete button bar exists at the bottom of the edit screen.
So I suggest to close this issue

Comment by Ryan Thrash (rthrash) - Thursday, 08 May 2008, 04:33PM
If the complete button bar exists at the bottom, then we need to make sure to remove the plugin from the installer, but I only see one instance of them in mutate_content_dynamic.php... :/

Comment by Brunaud (coroico) - Sunday, 11 May 2008, 03:51PM
BottomButtonBar plugin is still in use. Provided with MODx. Garry has been done the proposed correction (use of $_lang). Disabled the plugin remove the bottom button bar.