Login!
Register as a new user Lost password?
 

MODx Bug/Feature Tracker and Feature Requests

Welcome to the MODx CMS Tracker. Please choose the appropriate project from the drop down menu and provide as much information as possible regarding your server environment and browser. Thanks!

FS#635 — QuickEdit outputs <quickedit:content /> on logout

Attached to Project — MODx
Opened by Kevin Yank (kyank) - Thursday, 02 November 2006, 03:18PM
Last edited by Ryan Thrash (rthrash) - Saturday, 30 December 2006, 02:23PM
Task Type Bug Report
Category Plugin/Module/Snippet
Status Confirmed
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version 0.9.5 beta5
Due in Version 0.9.7
Due Date Undecided
Percent Complete 0%

Details

When viewing a page with the QuickEdit toolbar and one or more QuickEdit-enabled TVs visible, click "go > Logout". The resulting page contains an invalid <quickedit:content /> tag for each QuickEdit-enabled field.

EDIT: More specifically, for each field with an edit button (ie [*#content*] in template rather than [*content*]). The fields editable via the QE dropdown menu do not leave any footprint in the cached page.

Users who keep [*# style face two issues : one is that it affects validation, and the second is that it is theoretically a means by which someone could determine that the page was powered by MODx. Any solution should ideally address both complaints.
This task depends upon

This task blocks these from closing
Comment by Cassiel (Cassiel) - Tuesday, 14 November 2006, 06:10AM
I've stumbled with this bug too, but I don't need to logout to make it appear, it's the contrary.

According to my tests, the <quickedit:content /> tag is added to the cached version of the document if the first call to the document (outside the manager) is made by a QuickEdit enabled session, meaning you're logged in the manager (in another browser tab/window). If you log out before calling the document for the first time (outside the manager), there won't be any extra tags added.

BTW, I'm using MODx 0.9.5 RC2 and Firefox 2.

Comment by Kevin Yank (kyank) - Tuesday, 14 November 2006, 06:27AM
Yes, that matches what I'm seeing.

QuickEdit needs to bypass the cache somehow when the user is logged in to the manager.

Comment by Cassiel (Cassiel) - Wednesday, 15 November 2006, 10:00PM
Ah, forgot to mention that in order to be able to reproduce the bug, you have to enable the cache, meaning you have to disable the TemplateSwitcher plugin.

Comment by Paul Gregory (PaulGregory) - Thursday, 16 November 2006, 07:30AM
This is related to the use of [*#content*]. The # makes some part of QuickEdit insert that <quickedit:content /> tag, which it later replaces with that "Edit this content" button.

If you use [*content*] in your template instead, the tag is not put in, the button does not appear, but you can still edit Content from the QuickEdit menu. As I find that the button screws up layout too much, I prefer not to use #content anyway.

This issue can therefore be fixed by the end user without a great loss of functionality.

Therefore, whilst this issue needs to be addressed, the workaround is so simple for those people to whom this matters, that I cannot see that it is of any great priority and should not hold up the release of 0.9.5.

Comment by Paul Gregory (PaulGregory) - Thursday, 16 November 2006, 07:44AM
I've updated the bug report. One solution would be to use a valid DIV or something instead of <quickedit:content />, but <div id="quickedit_content"></div> may still be a clue that the site is powered by MODx - thus not addressing the secondary concern.

Comment by Cassiel (Cassiel) - Thursday, 16 November 2006, 08:37AM
I think your div solution is neat and simple. And the div id name could be changed in the plugin if needed or wanted.

Comment by Adam Crownoble (aNoble) - Thursday, 16 November 2006, 09:25AM
I'll take a look at this and see if I can get it fixed. The QuickEdit plugin should be removing any <quickedit> tags it finds before the page is output.

Comment by Paul Gregory (PaulGregory) - Thursday, 16 November 2006, 10:17AM
Overriding the name of the div id is a good idea. One thing to note however is that the <quickedit:content /> method is documented as a way of deliberately adding fields to QE, so the documentation should change, or both methods should be checked for.