MODx CMS and PHP Application Framework Bugtracker

Attached to Project — MODx
Opened by Kuno Floez-Mausegatt (kuno) - Tuesday, 29 January 2008, 08:06AM
Last edited by Ryan Thrash (rthrash) - Tuesday, 29 January 2008, 08:32AM

Task Type	Bug Report
Category	Core Distribution
Status	Waiting on User
Assigned To	No-one
Operating System	All

Severity	Low
Priority	Normal
Reported Version	0.9.6.1
Due in Version	0.9.6.2
Due Date	Undecided
Percent Complete

Details

When "duplicate aliases" is set to NO, in save_content.processor.php it is checked, wether the alias already exists. If so, you append a number to the alias to create a new one.

// check if alias already exists. if yes then append $cnt to alias
$cnt = $modx->db->getValue("SELECT count(*) FROM " . $tblsc . " WHERE id<>'$id' AND alias ='$alias'");
if ($cnt > 0)
$alias .= $cnt;
}

But if Alias is Unique (no duplicates), count(*) will always get 1 and there will be one page called "xy" and many pages called "xy1". Which is not further checked :-(

Instead you should check for
WHERE id<>'$id' AND alias LIKE '$alias%'");
so the number will be increased to more than 1... and there will be "xy", "xy1", "xy2"...